Log impacted features#16526
Merged
kokosing merged 1 commit intotrinodb:masterfrom Mar 14, 2023
Merged
Conversation
This is helpful in CI to understand the context on how tests are executed. Impacted features are passed as a log file and then they are passed from suite to test run, so logging them here make sure if everything is passed correctly.
| if (impactedFeaturesFile.isPresent()) { | ||
| try { | ||
| this.impactedFeatures = Optional.of(Files.asCharSource(impactedFeaturesFile.get(), StandardCharsets.UTF_8).readLines()); | ||
| log.info("Impacted features: %s", this.impactedFeatures); |
Member
There was a problem hiding this comment.
Doesn't hurt to print it here but we already print this in the CI: https://github.com/trinodb/trino/blob/master/.github/workflows/ci.yml#L809
Member
Author
There was a problem hiding this comment.
I know. But it is a different job. So printing here saves me clicking ;)
nineinchnick
approved these changes
Mar 13, 2023
ebyhr
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log impacted features
This is helpful in CI to understand the context on how tests are
executed.
Impacted features are passed as a log file and then they are passed from
suite to test run, so logging them here make sure if everything is
passed correctly.